Update API tool_panels route conditions #16991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly specify operation so tool_panels are included in apispec & thus docs
Without any specified conditions, the APIspec doesn't know what actions the endpoint supports and lists no actions, even though it's a valid endpoint.
Do we ever deviate from the action being GET in the situation where it's a custom action name/function (i.e. -- not one of the default resource names 'index', 'create', 'show', etc)? If we do not, then we could update build_apispec to assume GET if not specified, but we'd really want to double check that.
How to test the changes?
(Select all options that apply)
License