Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API tool_panels route conditions #16991

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Nov 8, 2023

explicitly specify operation so tool_panels are included in apispec & thus docs

Without any specified conditions, the APIspec doesn't know what actions the endpoint supports and lists no actions, even though it's a valid endpoint.

Do we ever deviate from the action being GET in the situation where it's a custom action name/function (i.e. -- not one of the default resource names 'index', 'create', 'show', etc)? If we do not, then we could update build_apispec to assume GET if not specified, but we'd really want to double check that.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Nov 8, 2023
@martenson martenson merged commit 2319bc3 into galaxyproject:dev Nov 11, 2023
49 of 51 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants