-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Global Drag-and-Drop feature for Upload component #16995
Conversation
…hrome, Firefox, Safari)
There is just one more change I need to make to ensure the drop-zone gets triggered on cases when the user first hovers over the center panel --hovering over the right or left panel immediately triggers the drop-zone but the center zone does not. |
Actually, I retract that last statement - it seems to be working about 95% of the time and I am unable to replicate it. Thought it might be a DOM |
I encountered something similar, when first developing this feature. It happens on the start page because of the iframe. |
@ElectronicBlueberry Thank you! I just got a good recommendation on how to test this potential IFrame issue so I can capture it for fixing. So will try that shortly and report back. |
…ive/unclickable. Includes, handling multiple iFrame DOM selectors like nested iFrames which are occasionally visible on the Home Page in the form of a carousel feature which can interfere with the Global Upload feature. This method is being used to disable the mouse-pointer on the background iFrame DOM elements when the file is being dragged over the semi-transparent Global Upload feature.
…event interruption of Drag-and-Drop state machine
Wording updated, suggestion accepted. Co-authored-by: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Addresses issue #16870
Changes include: larger drop zone, Toaster on file drop zone fail, and color highlighting
Updated wording
How to test the changes?
(Select all options that apply)
License