Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Global Drag-and-Drop feature for Upload component #16995

Merged
merged 13 commits into from
Nov 27, 2023

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Nov 8, 2023

demo_16870_AFTER
Addresses issue #16870
Changes include: larger drop zone, Toaster on file drop zone fail, and color highlighting

Greenshot 2023-11-27 12 00 24

Updated wording

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@hujambo-dunia hujambo-dunia changed the title Upgrade component to remove Bootstrap dependency Enhance Global Drag-and-Drop feature for Upload component Nov 8, 2023
@hujambo-dunia hujambo-dunia marked this pull request as ready for review November 8, 2023 22:05
@github-actions github-actions bot added this to the 23.2 milestone Nov 8, 2023
@hujambo-dunia
Copy link
Contributor Author

There is just one more change I need to make to ensure the drop-zone gets triggered on cases when the user first hovers over the center panel --hovering over the right or left panel immediately triggers the drop-zone but the center zone does not.

@hujambo-dunia
Copy link
Contributor Author

There is just one more change I need to make to ensure the drop-zone gets triggered on cases when the user first hovers over the center panel --hovering over the right or left panel immediately triggers the drop-zone but the center zone does not.

Actually, I retract that last statement - it seems to be working about 95% of the time and I am unable to replicate it. Thought it might be a DOM Focus(); issue, but couldn't replicate it. Happens sporadically on Chrome for Mac OS. Provided the user who recommended it, accepts the change - I think we should move forward with the merge and just keep our eye open if the issue appears once it goes to the Production environment.

@ElectronicBlueberry
Copy link
Member

I encountered something similar, when first developing this feature. It happens on the start page because of the iframe.
If you manage to move your mouse fast enough, so it appears directly within the iframe without traveling over any other components, the overlay will not show. I do not think this can be worked around.

@hujambo-dunia
Copy link
Contributor Author

I encountered something similar, when first developing this feature. It happens on the start page because of the iframe. If you manage to move your mouse fast enough, so it appears directly within the iframe without traveling over any other components, the overlay will not show. I do not think this can be worked around.

@ElectronicBlueberry Thank you! I just got a good recommendation on how to test this potential IFrame issue so I can capture it for fixing. So will try that shortly and report back.

…ive/unclickable. Includes, handling multiple iFrame DOM selectors like nested iFrames which are occasionally visible on the Home Page in the form of a carousel feature which can interfere with the Global Upload feature. This method is being used to disable the mouse-pointer on the background iFrame DOM elements when the file is being dragged over the semi-transparent Global Upload feature.
client/src/composables/fileDrop.ts Outdated Show resolved Hide resolved
client/src/composables/fileDrop.ts Outdated Show resolved Hide resolved
…event interruption of Drag-and-Drop state machine
Wording updated, suggestion accepted.

Co-authored-by: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
@dannon dannon merged commit 0b6d086 into galaxyproject:dev Nov 27, 2023
26 checks passed
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants