Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent excessive api/tool_panels calls by keeping views in store #17039

Merged

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Nov 16, 2023

Also remove extra api call added by mistake in #17021

The call api/tool_panels is used to get the dict of panel views for the ToolPanel when mounted, but this meant collapsing and expanding the tool panel over and over would produce multiple, needless calls. Instead, store the views and default_panel_view from this call in the toolStore and only fetch them once.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan force-pushed the excessive_tool_panels_api_calls_bug branch from 6795ebb to 63ffa74 Compare November 16, 2023 18:45
@ahmedhamidawan
Copy link
Member Author

Failing test:

FAILED test/integration_selenium/test_history_import_export_ftp.py::TestHistoryImportExportFtpSeleniumIntegrationWithTasks::test_history_export_tracking - selenium.common.exceptions.TimeoutException: Message: Timeout waiting on CSS selector [.directory-form-input] to become clickable.

seems unrelated to the toolStore and tool panel changes here

@davelopez davelopez merged commit 143d35d into galaxyproject:dev Nov 28, 2023
25 of 26 checks passed
@davelopez
Copy link
Contributor

Thanks @ahmedhamidawan!

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants