Allow relative URLs in broadcasts action links #17042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
force-pushed
the
fix_broadcasts_action_url_type
branch
from
921176a
to
81a6006
Compare
davelopez
force-pushed
the
fix_broadcasts_action_url_type
branch
from
81a6006
to
5488abb
Compare
davelopez
changed the title
mvdbeek
reviewed
Nov 21, 2023
mvdbeek
approved these changes
Nov 21, 2023
davelopez
force-pushed
the
fix_broadcasts_action_url_type
branch
2 times, most recently
from
8de42b7
to
48cb220
Compare
This will always fall back to a string, but the intention of the code reads better and we may add some custom validation later to really check for the URL correctness. Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
davelopez
force-pushed
the
fix_broadcasts_action_url_type
branch
from
48cb220
to
fe7ad2e
Compare
|
Do we need to backport this to 23.1 ? |
|
Yes it might be a good idea, there is no admin panel for it in 23.1 but can be an issue when using the API, I will take care of it 👍 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17033
It relaxes the schema typing in notifications a bit to support relative URLs. The pydantic type
AnyUrlalways confuses me and makes me think it supports both absolute and relative URLs but it's not the case.How to test the changes?
License