Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Prevent workflow submission with missing input values #17048

Merged
merged 4 commits into from Nov 20, 2023
Merged

[23.1] Prevent workflow submission with missing input values #17048

merged 4 commits into from Nov 20, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 17, 2023 •
edited

Fixes #16951 and #11182

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the base branch from dev to release_23.1 November 17, 2023 14:52
@mvdbeek mvdbeek changed the title Prevent workflow submission missing input value [23.1] Prevent workflow submission missing input value Nov 17, 2023
@mvdbeek
Disallow empty inputs on required input parameters in simplified work…
da127b5 
…flow form

This is another attempt at
galaxyproject#13220, but taking into
account
galaxyproject#13220 (comment)
by limiting this to the simplified workflow form, where we can assume
input parameter optionality to have the correct meaning.

This makes it harder to submit a mandatory text parameter that can be
empty, but that is (at this point at least) a very fringe requirement.

If really needed you can make the parameter optional (and use pick_value
to fill in an empty string if null is not OK as a value).
@mvdbeek mvdbeek changed the title [23.1] Prevent workflow submission missing input value [23.1] Prevent workflow submission with missing input values Nov 17, 2023
@mvdbeek mvdbeek mentioned this pull request Nov 17, 2023
Closed
@martenson martenson added this to the 23.2 milestone Nov 17, 2023
@mvdbeek mvdbeek marked this pull request as ready for review November 20, 2023 13:39
@mvdbeek mvdbeek merged commit 4659546 into galaxyproject:release_23.1 Nov 20, 2023
40 of 41 checks passed
This was referenced Nov 20, 2023
Closed
Closed
Closed
@martenson martenson deleted the prevent_workflow_submission_missing_input_value branch November 20, 2023 19:30
@mvdbeek mvdbeek mentioned this pull request Nov 21, 2023
Closed
4 tasks
@dannon dannon mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/workflows kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvdbeek @dannon @jmchilton @martenson