Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notification message input multi-line #17091

Merged

Conversation

davelopez
Copy link
Contributor

This is a very minor change, but the single-line text input was messing with the markdown format if you updated an existing notification message from the Notifications Admin Panel.

Before

image

After

image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson martenson merged commit c36d001 into galaxyproject:dev Nov 28, 2023
27 checks passed
@martenson
Copy link
Member

thanks @davelopez

@davelopez davelopez deleted the fix_admin_notification_message_input branch November 29, 2023 08:41
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants