Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Implement missing upload for S3 file sources #17100

Conversation

davelopez
Copy link
Contributor

Fixes #17089

I tested it locally using https://github.com/scireum/s3ninja

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek merged commit f3a6f4f into galaxyproject:release_23.1 Nov 29, 2023
37 of 38 checks passed
@davelopez davelopez deleted the 23.1_implement_missing_s3fs_upload branch November 29, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants