Towards SQLAlchemy 2.0: fix last cases of RemovedIn20Warning #17132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
area/workflows
area/database
jdavcs
force-pushed
the
dev_sa20_fix23
branch
from
74e70af
to
aba2614
Compare
"RemovedIn20Warning: The legacy calling style of select() is deprecated and will be removed in SQLAlchemy 2.0."
"RemovedIn20Warning: The connection.execute() method in SQLAlchemy 2.0 will accept parameters as a single dictionary"
"RemovedIn20Warning: Retrieving row members using strings or other non-integers is deprecated"
Note: I think we never needed this method here; select_from is all we need.
Note: this was happening because the connection object was retrieved from the session, which means that it may have been in a transaction. What we need is a *new* connection, which we obtain directly from the engine - so we know it's not in a transaction.
jdavcs
force-pushed
the
dev_sa20_fix23
branch
from
5c99da4
to
4664534
Compare
jdavcs
changed the title
|
This PR was merged without a "kind/" label, please correct. |
jdavcs
added
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #12541
Fixes last explicit warnings triggered by Galaxy tests.
How to test the changes?
(Select all options that apply)
License