Create pydantic model for the return of show operation - get: /api/jobs/{job_id}

[heisner-tillman]

This extends the work done in #16778

Summary

• Operation now returns pydantic model

How to test the changes?

• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/jobs/show_job_api_jobs__job_id__get

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[heisner-tillman]

The API test are failing because the pydantic model - ShowJobResponse- for the show operation, does not allow the field galaxy_version to be set to None. If I allow None there the tests succeed. Is this intended?

[davelopez]

For the look of the test failures and a bit of debugging, it seems the jobs that can have the galaxy_version as None are those of imported datasets from a history archive.

Now the actual reason they don't have a galaxy_version I wasn't sure, my guess was the job information associated with the dataset that gets serialized on the export archive was missing the galaxy_version or it was ignored/skipped when importing the job information.

After some more debugging, It turned out the job's galaxy version was serialized, but not imported back.

If you add galaxy_version to the list of ATTRIBUTES here:

galaxy/lib/galaxy/model/store/__init__.py

Line 1544 in f10614e

ATTRIBUTES = (

It should fix the test failures. Whether not including this was intentional or an oversight I don't know, but if it was an oversight the typing of the models helped us discover it :)

[mvdbeek]

Thanks a lot @heisner-tillman!

[github-actions]

This PR was merged without a "kind/" label, please correct.