Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix url_for in tool error reports #17210

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Dec 19, 2023

Partial backport of #17058 to 23.1

Reported by @natefoo on Matrix:

Bug reports on .org are suddenly sporadically failing url_for here:

return DEPRECATED_URL_ATTRIBUTE_MESSAGE
meaning the error report emails have no links
I haven't figured out yet under what conditions it works (that it's sporadic like this is weird enough).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek merged commit 1ffcf8e into galaxyproject:release_23.1 Dec 19, 2023
37 of 39 checks passed
@davelopez davelopez deleted the 23.1_partial_backport_of_#17058 branch December 19, 2023 12:07
@natefoo
Copy link
Member

natefoo commented Dec 19, 2023

Thanks @davelopez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants