Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped Store Refactor and Store Composition Refactor #17304

Merged
merged 4 commits into from Jan 16, 2024

Conversation

ElectronicBlueberry
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry commented Jan 16, 2024

Refactors scoped stores to use a custom defineScopedStore function, reducing nesting, repeated code and potential for errors.

Also refactors all stores using scope (currently just Workflow Stores) to composition.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry ElectronicBlueberry added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jan 16, 2024
@github-actions github-actions bot added this to the 24.0 milestone Jan 16, 2024
@mvdbeek mvdbeek merged commit 412016f into galaxyproject:dev Jan 16, 2024
32 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jan 16, 2024

Very cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants