Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quotas ID encoding #17335

Merged
merged 2 commits into from Jan 22, 2024
Merged

Fix quotas ID encoding #17335

merged 2 commits into from Jan 22, 2024

Conversation

davelopez
Copy link
Contributor

Fixes #17306

Using model_construct will not auto-encode the IDs.

How to test the changes?

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.0 milestone Jan 22, 2024
mvdbeek
mvdbeek approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also add a small test case for that ?

@davelopez davelopez marked this pull request as draft January 22, 2024 15:45
@davelopez davelopez marked this pull request as ready for review January 22, 2024 16:58
@davelopez
Copy link
Contributor Author

davelopez commented Jan 22, 2024 •
edited

I added a test that fails without these changes, but I'm just checking if the ID is of type string (instead of int), I hope that's ok. Is there a better way to check? Maybe checking /api/configuration/decode/{encoded_id} as admin or is it too much?

nsoranzo
nsoranzo approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added test looks perfect, thanks!

@nsoranzo nsoranzo merged commit a11f77d into galaxyproject:dev Jan 22, 2024
54 checks passed
@davelopez davelopez deleted the fix_quotas_id_encoding branch January 22, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/API kind/bug
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

ids not encoded in response from GET /api/quotas
3 participants
@davelopez @nsoranzo @mvdbeek