Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit cache_ok attribute to JSONType subclass #17376

Merged
merged 1 commit into from Jan 29, 2024
Merged

Add explicit cache_ok attribute to JSONType subclass #17376

merged 1 commit into from Jan 29, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 29, 2024

As for the other JSONType subclasses this is safe.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Jan 29, 2024
@github-actions github-actions bot added the area/database Galaxy's database or data access layer label Jan 29, 2024
@github-actions github-actions bot added this to the 24.0 milestone Jan 29, 2024
@mvdbeek
Add explicit cache_ok attribute to JSONType subclass
e4147f7 
As for the other JSONType subclasses this is safe.
@mvdbeek mvdbeek mentioned this pull request Jan 29, 2024
Closed
@nsoranzo nsoranzo merged commit f81cc1b into galaxyproject:dev Jan 29, 2024
51 of 52 checks passed
@nsoranzo nsoranzo deleted the cache_ok branch January 29, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvdbeek @nsoranzo