Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix the purge historyless HDAs pgcleanup action #17382

Merged

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Jan 29, 2024

Fixes two errors:

psycopg2.errors.AmbiguousColumn: column reference "id" is ambiguous
LINE 8:                 RETURNING id),
                                  ^

And

AttributeError: 'Record' object has no attribute 'recalculate_disk_usage_user_id'

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. UPDATE history_dataset_association SET history_id = null WHERE id = 1;
      
    2. python ./scripts/cleanup_datasets/pgcleanup.py -d -o 0 purge_historyless_hdas
      

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Jan 29, 2024
@jdavcs jdavcs self-requested a review January 29, 2024 16:34
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! (Thanks for providing manual testing instructions!)

@natefoo
Copy link
Member Author

natefoo commented Jan 29, 2024

Thanks for the speedy review @jdavcs 😃

@natefoo natefoo merged commit 3aeb4bc into galaxyproject:release_23.2 Jan 29, 2024
42 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants