Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge groups and roles from DB (for real) #17411

Merged
merged 10 commits into from Feb 2, 2024

Conversation

davelopez
Copy link
Contributor

Fixes #15350

In addition to removing the purged groups and roles from DB. Increases a bit the test coverage, includes some small refactorings, and makes some error codes more explicit and consistent between both APIs:

  • Returning 409 (Conflict) when creating/updating a role and the name is already in use.
  • Returning 404 (instead of 400) when the role doesn't exist or the user doesn't have access to it.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

Very nice

@mvdbeek mvdbeek merged commit bbfc042 into galaxyproject:dev Feb 2, 2024
53 of 54 checks passed
@davelopez davelopez deleted the purge_groups_and_roles_from_db branch February 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

names from deleted and purged roles/groups can not be reused
3 participants