Clean up some twilltestcase methods. #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davebx
commented
Feb 16, 2016
davebx
commented
- Remove twilltestcase.logout() from individual test methods.
- Add an optional (default enabled) logout step during twilltestcase.login()
davebx
added
kind/refactoring
| @@ -1519,6 +1522,7 @@ def login( self, email='test@bx.psu.edu', password='testuser', username='admin-u | |||
| def logout( self ): | |||
| self.visit_url( "%s/user/logout" % self.url ) | |||
| self.check_page_for_string( "You have been logged out" ) | |||
| tc.browser.cj.clear() | |||
There was a problem hiding this comment.
I think that this addition (and the one in galaxy_logout()) are causing the Tool Shed test failures. The reason is that clearing the browser cookies will logout both the Galaxy and TS sessions.
There was a problem hiding this comment.
That's a good point. I'll update it to clear TS xor galaxy.
|
👍 |
guerler
added a commit
that referenced
this pull request
Feb 18, 2016
Clean up some twilltestcase methods.
|
This PR was merged without a milestone attached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.