Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gxadmin to docker and update branch #17521

Merged
merged 2 commits into from Feb 21, 2024
Merged

Add gxadmin to docker and update branch #17521

merged 2 commits into from Feb 21, 2024

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Feb 21, 2024 •
edited

The gxadmin part is optional, but we do need to update the pinned branch so pykube-ng changes take effect.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

ksuderman
ksuderman approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@ksuderman ksuderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuwang nuwang marked this pull request as ready for review February 21, 2024 16:07
@github-actions github-actions bot added this to the 24.0 milestone Feb 21, 2024
@nuwang nuwang merged commit c6fa453 into galaxyproject:dev Feb 21, 2024
51 of 53 checks passed
@nuwang nuwang deleted the add_gxadmin_to_docker branch February 21, 2024 16:07
@github-actions GitHub Actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgane afgane afgane approved these changes

@ksuderman ksuderman ksuderman approved these changes

Assignees
No one assigned
Labels
area/deployment kind/enhancement
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nuwang @afgane @ksuderman