Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix tool panel workflow and favorites button bugs #17634

Merged

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    da8e1e1 View commit details
    Browse the repository at this point in the history
  2. fetch panel view in case the view string changes but panel isn't stored

    This can happen if the user has Galaxy open on 2 windows, and they changed the panel view, it will show up on one, and would keep loading on the other since the panel isn't populated (panel string is stored in `localStorage` and panel views in the pinia store; both don't get updated simultaneously.
    ahmedhamidawan committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b20a52b View commit details
    Browse the repository at this point in the history
  3. convert FavoritesButton to composition+ts...

    ... as this also fixes the "could not find icon" error.
    ahmedhamidawan committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8bc5c7a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    07deeff View commit details
    Browse the repository at this point in the history
  2. fix bug where reloading ToolsList would show nothing

    If you reloaded `ToolsList` with no filters, instead of showing the entire toolset, it would show no results. This was because `itemsLoaded` needed to be a reactive computed value instead of a ref.
    ahmedhamidawan committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    1e0d665 View commit details
    Browse the repository at this point in the history
  3. change unfavorite tool api route:{object_id} to {object_id:path}

    Tools with `/` in their id couldn't be unfavorited because the URI wouldn't be encoded
    ahmedhamidawan committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d57341e View commit details
    Browse the repository at this point in the history