Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax for SA2.0 #17663

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix syntax for SA2.0 #17663

merged 1 commit into from
Mar 12, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Mar 11, 2024

This will break under SQLAlchemy 2.0. New select syntax: select(foo, bar), not select([foo, bar]).

(Just noticed: was added in #17488)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Mar 11, 2024
@jdavcs jdavcs added this to the 24.0 milestone Mar 11, 2024
@jmchilton jmchilton merged commit 63cbae8 into galaxyproject:dev Mar 12, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants