Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Don't require history to calculate anon disk usage #17765

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 16, 2024

This is probably the simplest way to fix the anon user issue. If we don't have a history the size is 0, that's fairly simple.

We might still want to do #17755 for those FastAPI endpoints that do actually require a default history.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This is probably the simplest way to fix the anon user issue.
If we don't have a history the size is 0, that's fairly simple.

We might still want to do galaxyproject#17755
for those FastAPI endpoints that do actually require a default history.
@github-actions github-actions bot added this to the 24.1 milestone Mar 16, 2024
which relied on receiving 400
@martenson martenson modified the milestones: 24.1, 24.0 Mar 17, 2024
@martenson martenson merged commit 7b88bcd into galaxyproject:release_24.0 Mar 17, 2024
50 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 17, 2024
@nsoranzo nsoranzo deleted the fix_anon_no_history_users_current branch March 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants