-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidates data dialog components #17802
Conversation
29a6eef
to
6e0d54c
Compare
I'd really like the ability to extend the Markdown editor components with the ability to customize the form for each directive you insert with added option (e.g. add an optional footer, select a size from a dropdown, etc..). Mostly these are all just these selection dialogs currently. I hope you can keep this use case in mind as you refactor these! |
73b5a3d
to
d67ac21
Compare
… selection dialog component
@jmchilton absolutely, the goal of this refactoring is to simplify the overall structure while at the same allowing for more flexibility. As we go along we can easily add additional slots to extend or replace the footer or other components as necessary. I'd be happy to help with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My gut says I don't think that slots is the right approach - the Markdown pickers are not data pickers with extra options they are a set of options that include data as one. Conceptually not a huge difference but I think it guides one to a different approach. The right approach would be to extract the stuff inside the modal as a component that could be included in other modals not making the existing modal more complex and having to deal with the complexity of the existing modal. I think that sort of leads us down the road of Forms and Grids - where you think there should be a big hyper-parameterizable mega widget and I think we should have smaller composable ones even if that means a lot more duplication. You're a brilliant developer though and I understand your vision and I know you always find a way to make it work and work well. I'm happy to try it your way - especially if you were willing to do the work on a few of the markdown components to outline what it should look like.
@jmchilton I will definitely put the work in to adjust this as needed as we go along, while avoiding over engineered frameworks with overly complex components and a huge number of props. I really appreciate it. Thank you! |
This PR consolidates data dialog components and converts them to composition api and type script. This is a preparation for upcoming changes to the data dialog functionality. Additionally this PR decomposes some of the nested abstraction layers. Moving forward it should be easier for us to make additions or customize the data dialog for use in different contexts.
How to test the changes?
(Select all options that apply)
License