Dataset information refactors #17804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itisAliRH
changed the title
davelopez
reviewed
Apr 8, 2024
client/src/components/DatasetInformation/DatasetAttributes.test.ts
Outdated
Show resolved
Hide resolved
client/src/components/DatasetInformation/DatasetAttributes.test.ts
Outdated
Show resolved
Hide resolved
client/src/components/DatasetInformation/DatasetInformation.vue
Outdated
Show resolved
Hide resolved
itisAliRH
force-pushed
the
dataset-information-refactors
branch
from
75d73dd
to
ce2559b
Compare
…ilsProvider` and `JobProblemProvider
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
…etHash` type from API
…, `DatasetSources` and `DatasetSourceTransform` components
…type from `DatasetInformation/services` to `api/jobs`
itisAliRH
force-pushed
the
dataset-information-refactors
branch
from
f7e17b6
to
9c9bf57
Compare
davelopez
approved these changes
Apr 15, 2024
|
This PR was merged without a "kind/" label, please correct. |
nsoranzo
added
the
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the dataset information components to use CompositionAPI and typescript, imports icons and bootstrap components, removes
DatasetAttributesProviderandJobProblemProviderproviders, and more logic improvements.One of the unit tests for
DatasetError("does not hide form fields and button on error") was dropped because it required more complexity to pass. There are two problems:mockFetchercan’t throw an error on error statuses and all errors need to be handled in service filesI could not find elsewhere that we are checking API errors in unit tests (it should be a way to do it)
Moreover, the
"/api/jobs/{job_id}/error"API returns a status code of 200 when any error occurs, such as when the mail is not configured. Additionally, the error message returned by the API is an array instead of the common types we are using.How to test the changes?
(Select all options that apply)
License