Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for temporary upload file for API uploads #17850

Merged

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Mar 27, 2024

I noticed that workflow test upload jobs jobs fail when testing against my instance (which uses a real user setup). Problem is that the temporary upload file does not respect the umask (because files created using tempfile just do not do this).

The quick fix implemented here is fixing this by changing the permissions. Note that uploads via the web interface are not affected because they go this way.

Ultimately: it might be better to store the files in the job working dir, but this task seems to be to large for me.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Mar 27, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Mar 27, 2024

it might be better to store the files in the job working dir

that isn't possible, uploads start before any job exists

@mvdbeek mvdbeek merged commit e9db363 into galaxyproject:dev May 14, 2024
54 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants