Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Embed fix #17852

Merged
merged 1 commit into from Mar 28, 2024
Merged

Conversation

ElectronicBlueberry
Copy link
Member

The iframe generated by the embed settings was broken. Turns out iframes can't be self-closing, til!
Also added some base styles, which are likely required quite often.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ElectronicBlueberry ElectronicBlueberry added this to the 24.0 milestone Mar 27, 2024
@mvdbeek mvdbeek merged commit f4115bb into galaxyproject:release_24.0 Mar 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants