Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailing list wording tweaks #17867

Merged
merged 1 commit into from
May 14, 2024
Merged

Mailing list wording tweaks #17867

merged 1 commit into from
May 14, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 29, 2024

Starting point for @natwhitaker -- here's an example of the changes you mentioned, take it from here! :)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon force-pushed the mailing-list-wording-tweaks branch from f33c156 to c449963 Compare March 29, 2024 20:02
@dannon dannon added this to the 24.1 milestone May 14, 2024
@mvdbeek mvdbeek removed this from the 24.1 milestone May 14, 2024
@natwhitaker
Copy link
Contributor

This looks good to me and covers what changes we had discussed! Thanks @dannon!

@dannon dannon marked this pull request as ready for review May 14, 2024 15:54
@dannon dannon merged commit 9fa7b04 into galaxyproject:dev May 14, 2024
31 checks passed
@github-actions github-actions bot added this to the 24.1 milestone May 14, 2024
@github-actions GitHub Actions
Copy link

This PR was merged without a "kind/" label, please correct.

@jdavcs jdavcs added area/documentation kind/refactoring cleanup or refactoring of existing code, no functional changes labels May 23, 2024
@itisAliRH itisAliRH deleted the mailing-list-wording-tweaks branch May 28, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/documentation kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dannon @natwhitaker @mvdbeek @jdavcs