Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tool panel insertion, rely on activity bar #17872

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 1, 2024

When displaying published items such as Workflows and Pages, a second, duplicate tool panel appears. One is displayed in the context of the activity bar, and the second one is inserted manually. This PR resolves this by removing the duplicate tool panel insertion.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.1 milestone Apr 1, 2024
@guerler guerler marked this pull request as ready for review April 1, 2024 15:52
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that only apply to dev or is this also an issue on 24.0 ?

@guerler
Copy link
Contributor Author

guerler commented Apr 2, 2024

Thanks for the review. Only applies to dev. In release this condition here avoids panel duplication: https://github.com/galaxyproject/galaxy/pull/17701/files#diff-1b3f63450eafc7d09add7008cc29ff519aac6103c7f4d167f0bc5207cc9b4b91L19. Added a commit to remove the now unused property.

@mvdbeek mvdbeek merged commit 1de33e4 into galaxyproject:dev Apr 2, 2024
30 checks passed
@itisAliRH itisAliRH deleted the fix_pages_view branch May 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants