[24.0] do not show copy button when editing

[martenson]

backport plus an addition to #17888

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

Maybe it'd be better to just disable the button ?

[martenson]

I generally think it better to hide things that are not relevant to the current view. And when editing slug copying of the full url is not relevant.

[davelopez]

In this case, there is not too much of a difference, but there are clear pros and cons for both options so we shouldn't always prioritize one or the other, but rather choose on a case-by-case basis.
Here is an article without the aim to bikeshed too much 😜 https://uxpsychology.substack.com/p/hidden-vs-disabled-states

[martenson]

I see both sides and my preference was in the commit. However since there are two votes for the other option I added cd7de55

[davelopez]

Thank you! I prefer this option because the UI is not very cluttered here and there is a bit less "movement" on the screen when interacting 👍