Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section divider to activity bar, fix click handler #18007

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 17, 2024

This PR adds a dotted line between the activity bars main and footer section. The main section is scrollable and as of right now still draggable while the items in the footer are fixed. Additionally this PR adds a drag-delay to resolve the convolution of click and drag handler triggers. Fixes: #16633.
Moving forward our goal is to move dragging of activities to the settings panel to improve accessibility.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.1 milestone Apr 17, 2024
@guerler guerler marked this pull request as ready for review April 17, 2024 13:44
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this works great! Could this target 24.0 so that main also gets this?

@ahmedhamidawan

This comment was marked as resolved.

@ahmedhamidawan ahmedhamidawan merged commit 10a0c58 into galaxyproject:dev Apr 18, 2024
35 checks passed
@martenson
Copy link
Member

Thank you @guerler !

@guerler guerler deleted the activity_divider branch April 23, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activity bar sometimes ignores clicks
3 participants