Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Visualization container, avoid using default iframe #18016

Merged
merged 8 commits into from
May 1, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 18, 2024

Currently Visualizations are displayed in the generic Galaxy main iframe, this requires manually setting the globally available iframes source attribute from another component, and hide the router-view. This PR adds a Visualization specific container which will allow navigating to Visualizations using router.push. This is a requirement for a more resilient visualization creation and displaying mechanism.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.1 milestone Apr 18, 2024
@guerler guerler force-pushed the visualization_frame branch 2 times, most recently from cb9e2ac to 17d0703 Compare April 24, 2024 09:08
@guerler guerler marked this pull request as ready for review April 24, 2024 09:09
@dannon dannon merged commit 142e409 into galaxyproject:dev May 1, 2024
55 checks passed
@guerler guerler deleted the visualization_frame branch May 2, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants