Refactor galaxy.files plugin loading + config handling. #18049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
kind/refactoring
|
This is great! Thanks! Let me know if I should open an early draft PR with those type annotations so we can discuss on them. xref: #18050 |
davelopez
approved these changes
Apr 25, 2024
|
@jmchilton can you rebase against dev to get those tests running ? |
|
Yep, was going to say exactly that, didn't know if 64be33e made it to |
- Downstream I want a way to load plugins from outside the ConfiguredFileSources class. - Adds some more typing as I went in there and refactored things.
jmchilton
force-pushed
the
files_typing_3
branch
from
733b4b3
to
ac197e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the changes?
(Select all options that apply)
License