Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Raise RequestParameterInvalidException when url is invalid #18155

Merged
merged 1 commit into from
May 15, 2024
Merged

[24.0] Raise RequestParameterInvalidException when url is invalid #18155

merged 1 commit into from
May 15, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 15, 2024 •
edited
Loading

Fixes #18154

Screenshot 2024-05-15 at 13 49 12

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone May 15, 2024
@mvdbeek mvdbeek changed the title [24.0] Raise RequestParameterInvalidException when url is invalid [24.0] Raise RequestParameterInvalidException when url is invalid May 15, 2024
jmchilton
jmchilton approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense to me - thanks for the fix!

@mvdbeek mvdbeek merged commit 5280a79 into galaxyproject:release_24.0 May 15, 2024
51 of 52 checks passed
@mvdbeek mvdbeek mentioned this pull request May 20, 2024
Closed
mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request May 27, 2024
@mvdbeek
Raise RequestParameterInvalidException if url can't be verified
30b1f4b 
Kind of a followup to
galaxyproject#18155.

Fixes:
```
ValueError
invalid literal for int() with base 10: 'sequences'
```
For the attempted url `"http://emp-single-end-sequences:sequences"`.
@mvdbeek mvdbeek mentioned this pull request May 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/API area/upload kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvdbeek @jmchilton