Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Prevent anonymous and inactive users from running workflows #18192

Merged
merged 3 commits into from
May 23, 2024
Merged

[24.0] Prevent anonymous and inactive users from running workflows #18192

merged 3 commits into from
May 23, 2024

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented May 21, 2024 •
edited
Loading

Fixes #18147

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone May 21, 2024
@ahmedhamidawan ahmedhamidawan removed this from the 24.1 milestone May 21, 2024
nsoranzo
nsoranzo reviewed May 21, 2024
View reviewed changes
Copy link
Member

@nsoranzo nsoranzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small API test for this please?

@mvdbeek
Copy link
Member

mvdbeek commented May 21, 2024

Can you add a small API test for this please?

This would need to be an integration test since we need an instance that is configured to require user activation.

@ahmedhamidawan ahmedhamidawan force-pushed the prevent_anon_users_run_workflow branch from 5edab06 to d0e460c Compare May 22, 2024 17:37
@ahmedhamidawan ahmedhamidawan changed the title [24.0] Prevent inactive users from running workflows [24.0] Prevent anonymous users from running workflows May 22, 2024
@github-actions github-actions bot added this to the 24.1 milestone May 22, 2024
@jdavcs jdavcs removed this from the 24.1 milestone May 23, 2024
@ahmedhamidawan @nsoranzo
Update lib/galaxy/webapps/galaxy/services/workflows.py
538570b 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@ahmedhamidawan ahmedhamidawan changed the title [24.0] Prevent anonymous users from running workflows [24.0] Prevent anonymous and inactive users from running workflows May 23, 2024
@github-actions github-actions bot added this to the 24.1 milestone May 23, 2024
@nsoranzo nsoranzo merged commit 7ab7475 into galaxyproject:release_24.0 May 23, 2024
50 of 51 checks passed
@ahmedhamidawan ahmedhamidawan linked an issue May 24, 2024 that may be closed by this pull request
Inactive users can schedule invocations #18147
Closed
@ahmedhamidawan ahmedhamidawan mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/backend kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

Inactive users can schedule invocations
4 participants
@ahmedhamidawan @mvdbeek @nsoranzo @jdavcs