Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Small bug fixes for user data plugins #18246

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

jmchilton
Copy link
Member

  • Fix upgrade icon in manage grid.
  • Fix missing tests for upgrading file sources.
  • Fix small doc string copy-paste issues.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all the tests!
Is it still WIP? Looks pretty solid to me!

client/src/components/ConfigTemplates/InstanceDropdown.vue Outdated Show resolved Hide resolved
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
@jmchilton jmchilton marked this pull request as ready for review May 31, 2024 13:07
@mvdbeek mvdbeek merged commit b3835bb into galaxyproject:release_24.1 Jun 4, 2024
45 of 53 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants