Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Move tool shed specific driver function to tool_shed.test #18296

Merged
merged 3 commits into from
Jun 1, 2024
Merged

[24.0] Move tool shed specific driver function to tool_shed.test #18296

merged 3 commits into from
Jun 1, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 31, 2024 •
edited by nsoranzo
Loading

Should fix #18282

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek mentioned this pull request May 31, 2024
Closed
@mvdbeek mvdbeek marked this pull request as ready for review May 31, 2024 17:57
@nsoranzo
Copy link
Member

nsoranzo commented Jun 1, 2024

Did you mean to target the release_24.0 branch?

@mvdbeek mvdbeek changed the base branch from dev to release_24.0 June 1, 2024 13:11
@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 1, 2024

Yes, thank you!

@nsoranzo nsoranzo merged commit 132ea2b into galaxyproject:release_24.0 Jun 1, 2024
54 of 56 checks passed
@nsoranzo nsoranzo deleted the untangle_shed_from_driver_util branch June 1, 2024 17:26
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/packaging area/testing kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

Extra dependency created in package integration_util by import of toolshed
3 participants
@mvdbeek @nsoranzo @jdavcs