[24.1] Fix various packages' issues #18301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the galaxy-config package wrongly depending on galaxy-app. Also move the carbon_emissions unit tests to the `app/` subdirectory. Refines @mvdbeek's proposed patch from galaxyproject#17159 (comment) . Close galaxyproject#17159 .
Also: - Add missing `graphene` and `graphql-core` dependencies to `pyproject.toml` (already installed as other dependencies' deps, but explicitly imported by ToolShed code). - Move `test_tool_validation.py` unit tests to the galaxy-tool-shed package.
Previously, when running pytest from `packages/test.sh`, it was using our main `pytest.ini` as configfile, therefore setting the wrong rootdir and using `lib` as `pythonpath`. This was hiding various packaging issues fixed in the previous commits.
4 tasks
|
Excellent, thank so much @nsoranzo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered another problem that was hiding various packaging issues: when running
pytestfrompackages/test.shit was using our mainpytest.inias configfile, therefore setting its rootdir wrong and usinglibaspythonpath(see https://docs.pytest.org/en/stable/reference/customize.html#initialization-determining-rootdir-and-configfile for how this works).This PR adds a
pytest.inifile to each package directory and fix the issues that this revealed (in particular the carbon data loading which was already known, see #17159).How to test the changes?
(Select all options that apply)
License