Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Disable state filter for collections in HistoryFilters #18324

Conversation

ahmedhamidawan
Copy link
Member

Fixes #18264

disable_state_filter_collections.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Select Collections Only from the content type filter dropdown to see the state filter disabled
    2. Select any state filter to see the content type filter disabled

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Adds a `disablesFilters` property to the `ValidFilter` class which allows for the functionality of disabling other filters given certain values for a given filter.

Note: This only works for ranged, input-field and dropdown type filters in the `FilterMenu`

Fixes galaxyproject#18264
@mvdbeek mvdbeek merged commit fcc5eb5 into galaxyproject:release_24.1 Jun 6, 2024
27 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jun 6, 2024

Thank you!

@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants