Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Drop unnecessary escaping for workflow name and annotation #18376

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 11, 2024

These shouldn't ever have been escaped before storing in the database, this should've always just been applied on the way out. We also don't need to do that anymore since we don't use v-html for these fields.

Fixes #18354

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

These shouldn't ever have been escaped before storing in the database,
this should've always just been applied on the way out. We also don't
need to do that anymore since we don't use `v-html` for these fields.

Fixes galaxyproject#18354
@mvdbeek mvdbeek merged commit 62b60bd into galaxyproject:release_24.0 Jun 12, 2024
50 checks passed
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants