Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Allow running and editing workflows for specific versions #18378

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Jun 11, 2024

This passes the version prop to the routes for editing and running workflows and also to the InvokeWorkflowPayload, so that users can run specific versions of workflows.

Fixes #18367

workflow_run_edit_for_version.mp4
Here, the user opens the run form for the latest version of the workflow (default), and then they switch to the older version (with a different name) and the run form loads with the correct (older) order of steps.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This passes the version prop to the routes for editing and running workflows and also to the `InvokeWorkflowPayload`, so that users can run specific versions of workflows.

Fixes galaxyproject#18367
Show the name corresponding to the `WorkflowRun` form workflow's version.
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would have preferred if we passed the workflow_id (and not the stored_workflow_id as we do currently) and the ?instance=true parameter instead. It's a bit unfortunate that I named our internal workflow checkpoints version when I added this. The version just corresponds to the number of workflows attached to a stored workflow, so if you import or copy a workflow that number is reset. This might be a little confusing.

@mvdbeek mvdbeek merged commit c60f03c into galaxyproject:release_24.1 Jun 12, 2024
49 of 52 checks passed
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this pull request Jun 14, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to.
Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this pull request Jun 18, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to.
Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this pull request Jun 18, 2024
This is a bug caused in galaxyproject#18378 which made the `SaveChangesModal` useless because the version before the save was routed to.
Now, we instead append the version to the route after the user confirms the save (or doesn't) in the modal.
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants