Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More warnings, less errors #1936

Merged
merged 2 commits into from Mar 16, 2016

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 16, 2016

This is as minor as it gets, but I think it is still important to have a clear idea of what is an error, and what is more of a warning.

  • 18a4edc when a user hasn't uploaded a file by FTP, the FTP directory (at least in our configuration) doesn't exist and an error is raised. This should be a warning, and the user still sees Your FTP directory does not contain any files.
  • 5c45746 when the metadata of a file exceeds a limit, the metadata won't be writtten to the database, and an error is raised. I think this should be a warning

@martenson
Copy link
Member

I think this is better.
thank you @mvdbeek !

martenson added a commit that referenced this pull request Mar 16, 2016
@martenson martenson merged commit 46dc26e into galaxyproject:dev Mar 16, 2016
@mvdbeek mvdbeek deleted the more_warnings_less_errors branch April 8, 2016 14:53
@galaxybot
Copy link
Contributor

This PR was merged without a 'kind/' tag, please correct.

@galaxybot
Copy link
Contributor

This PR was merged without a milestone attached.

@martenson martenson added this to the 16.04 milestone Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants