Fix transiently failing tool shed tests. #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments inline - I don't know why but the retry would fix the transient problems acording to the Jenkins tests with the previous exception added to verify this would fix the problem.
|
black magic I say! |
|
If there's a valid failure here in the naked exception, won't this go into an infinitely failing loop? (that is, maybe |
|
@dannon |
| @@ -548,18 +548,11 @@ def export_capsule( self, repository, aggressive=False, includes_dependencies=No | |||
| else: | |||
| try: | |||
| return self._export_capsule(repository, includes_dependencies=includes_dependencies) | |||
| except Exception as original_error: | |||
| except Exception: | |||
| # Emperically this fails occasionally, we don't know | |||
|
Argh, missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments inline - I don't know why but the retry would fix the transient problems acording to the Jenkins tests with the previous exception added to verify this would fix the problem.