Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide hidden data parameters in workflow editor #2120

Merged
merged 2 commits into from Apr 15, 2016

Conversation

Projects
None yet
4 participants
@guerler
Copy link
Contributor

commented Apr 8, 2016

Fixes #2050.

multiple=input.multiple,
extensions=input.extensions,
input_type="dataset", ) )
if isinstance( input, DataCollectionToolParameter ):

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 11, 2016

Member

s/if/elif/

just to make it clear.

collection_types=input.collection_types,
extensions=input.extensions,
) )
if hasattr( input, 'hidden' ) and not input.hidden:

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 11, 2016

Member

Not sure this is correct, I think this should be:

if not hasattr( input, 'hidden' ) or not input.hidden:

@guerler guerler added status/review and removed status/WIP labels Apr 12, 2016

@galaxybot galaxybot added this to the 16.07 milestone Apr 12, 2016

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2016

Thanks for the suggestions @nsoranzo.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Apr 13, 2016

👍

@jmchilton jmchilton merged commit 88db9e6 into galaxyproject:dev Apr 15, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.