Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move specific methods from shed_util_common.py to specific_util.py #2269

Merged
merged 15 commits into from Jun 7, 2016

Conversation

Projects
None yet
4 participants
@davebx
Copy link
Contributor

commented Apr 28, 2016

No description provided.

@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 4, 2016

get_repositories_by_category() method has been moved, but lib/galaxy/webapps/tool_shed/api/categories.py is not updated accordingly.

@davebx

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2016

Thanks, @nsoranzo. I've added a test for that endpoint, since the existing tests didn't catch that error.

davebx added some commits May 4, 2016

@davebx

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2016

I have more work to do on this, since the alternative is this pull request blocking the work I have going on in other files. WIP for now.

@davebx davebx added status/WIP and removed status/review labels May 5, 2016

@davebx davebx changed the title Move metadata-related methods from shed_util_common to metadata_util. [WIP] Move specific methods from shed_util_common.py to specific_util.py May 5, 2016

@davebx davebx added status/review and removed status/WIP labels May 16, 2016

@davebx davebx changed the title [WIP] Move specific methods from shed_util_common.py to specific_util.py Move specific methods from shed_util_common.py to specific_util.py May 16, 2016

@davebx davebx removed the status/WIP label May 16, 2016

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

I am 👍 on this, @nsoranzo do you have anything to add before I merge? (since you were also reviewing it before)

self.create_category( name='Test 0000 Basic Repository Features 2', description='Test 0000 Basic Repository Features 2' )
self.login( email=common.admin_email, username=common.admin_username )
category = self.create_category( name='Test 0000 Basic Repository Features 1', description='Test Description 0000 Basic Repository Features 1' )
category = self.create_category( name='Test 0000 Basic Repository Features 2', description='Test Description 0000 Basic Repository Features 2' )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jun 2, 2016

Member

The added category = at the start of this line changes the category in which the repository 'filtering_0000' is created. I guess that the test test_0015_browse_test_0000_category() below does not fail only because a repository of the same name is created in category 'Test 0000 Basic Repository Features 1' during a previous test.

This comment has been minimized.

Copy link
@davebx

davebx Jun 2, 2016

Author Contributor

Thanks, @nsoranzo. I'll update the code.

@martenson

This comment has been minimized.

Copy link
Member

commented Jun 7, 2016

looks good, thanks @davebx !

@martenson martenson merged commit c0b5a28 into galaxyproject:dev Jun 7, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 107 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Jun 8, 2016

Fix py34-lint tox test
Broken with the merge of galaxyproject#2269.

@nsoranzo nsoranzo referenced this pull request Jun 8, 2016

Merged

Fix py34-lint tox test #2469

@martenson martenson referenced this pull request Jun 8, 2016

Closed

fix broken TS tests #2470

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Jun 8, 2016

Re-add get_updated_changeset_revisions_from_tool_shed() method
It was accidentally removed in PR galaxyproject#2269.
Fix toolshed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.