Move specific methods from shed_util_common.py to specific_util.py #2269
Conversation
davebx
added
kind/refactoring
|
|
|
Thanks, @nsoranzo. I've added a test for that endpoint, since the existing tests didn't catch that error. |
|
I have more work to do on this, since the alternative is this pull request blocking the work I have going on in other files. WIP for now. |
davebx
changed the title
davebx
changed the title
|
I am 👍 on this, @nsoranzo do you have anything to add before I merge? (since you were also reviewing it before) |
| self.create_category( name='Test 0000 Basic Repository Features 2', description='Test 0000 Basic Repository Features 2' ) | ||
| self.login( email=common.admin_email, username=common.admin_username ) | ||
| category = self.create_category( name='Test 0000 Basic Repository Features 1', description='Test Description 0000 Basic Repository Features 1' ) | ||
| category = self.create_category( name='Test 0000 Basic Repository Features 2', description='Test Description 0000 Basic Repository Features 2' ) |
There was a problem hiding this comment.
The added category = at the start of this line changes the category in which the repository 'filtering_0000' is created. I guess that the test test_0015_browse_test_0000_category() below does not fail only because a repository of the same name is created in category 'Test 0000 Basic Repository Features 1' during a previous test.
There was a problem hiding this comment.
Thanks, @nsoranzo. I'll update the code.
|
looks good, thanks @davebx ! |
Broken with the merge of galaxyproject#2269.
It was accidentally removed in PR galaxyproject#2269. Fix toolshed tests
No description provided.