[16.04] Backport of 2230 #2284
Merged
[16.04] Backport of 2230 #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sanitizes some instances where tool parameters were included directly into the DOM. workflow/run.mako displayed the parameter as a value in a hidden input. This was base64 encoded as there was no better solution apparent at the time. I'm not sure where this parameter is POSTed to but we should figure that out and b64decode it, or remove the hidden parameter. client/... added the parameter value into the DOM. This was easily sanitized using a standard method. workflow/display.mako included the parameter value directly into the HTML. This was cgi.esacped Conflicts: static/scripts/bundled/libs.bundled.js.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2231; @erasche @natefoo
This sanitizes some instances where tool parameters were included
directly into the DOM.
workflow/run.mako displayed the parameter as a value in a hidden input.
This was base64 encoded as there was no better solution apparent at the
time. I'm not sure where this parameter is POSTed to but we should
figure that out and b64decode it, or remove the hidden parameter.
client/... added the parameter value into the DOM. This was easily
sanitized using a standard method.
workflow/display.mako included the parameter value directly into the
HTML. This was cgi.esacped
Conflicts:
static/scripts/bundled/libs.bundled.js.map