Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DCE count in collection and HDCA views #2326

Merged
merged 6 commits into from May 16, 2016

Conversation

Projects
None yet
2 participants
@carlfeberhard
Copy link
Contributor

commented May 9, 2016

Upshot:

  • returns the element count for HDCAs from the API by default
  • and displays them in HDCA subtitles (e.g. 'a list of 9 datasets')

Adds a serialization method for element_count to the HDCA API serializer used by history_contents (i.e. history/{:id}/contents). This returns the count of datasets (or subcollections in the case of list of pairs) in the HDCA. This field isn't returned by default and needs to be specifically requested using the keys parameter:

http://localhost:8080/api/histories/{:id}/contents?keys=type_id,element_count 

This PR waits 2 secs after the history contents have been loaded (so as to not bog down the initial load) and fetches the element_count for all HDCAs. This should allow the UI to remain responsive.

We'll have to see how bad this is when 1000s of HDCAs are being updated (and how that fits into #2126).

Resolves #400

carlfeberhard added some commits May 9, 2016

UI, HDCAs: render element_count when available
- Adds a change event for element_count that renders the subtitle
- Subtitle now renders the count or nothing if not available
UI & API, history: return element_count by default
- Adds element_count to summary serialization for hdcas through
history/{:id}/contents
- Implements a HistoryContents fetch method to decorate the hdcas
after loading if necessary
UI, history: get element_counts after history load
- Waits 2s after history contents loading and fetches element_count
for all dataset collections in the history
- Removes element_count as a default summary field for HDCAs
@carlfeberhard

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2016

@galaxybot test this

@dannon

This comment has been minimized.

Copy link
Member

commented May 16, 2016

image

@dannon

This comment has been minimized.

Copy link
Member

commented May 16, 2016

Looks good, shows up right away and updates totals 2 seconds after.

@dannon dannon merged commit ab60901 into galaxyproject:dev May 16, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:show-dce-count branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.