Show DCE count in collection and HDCA views #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a change event for element_count that renders the subtitle - Subtitle now renders the count or nothing if not available
- Adds element_count to summary serialization for hdcas through
history/{:id}/contents
- Implements a HistoryContents fetch method to decorate the hdcas
after loading if necessary
- Waits 2s after history contents loading and fetches element_count for all dataset collections in the history - Removes element_count as a default summary field for HDCAs
|
@galaxybot test this |
|
|
|
Looks good, shows up right away and updates totals 2 seconds after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upshot:
Adds a serialization method for
element_countto the HDCA API serializer used by history_contents (i.e. history/{:id}/contents). This returns the count of datasets (or subcollections in the case of list of pairs) in the HDCA. This field isn't returned by default and needs to be specifically requested using thekeysparameter:This PR waits 2 secs after the history contents have been loaded (so as to not bog down the initial load) and fetches the element_count for all HDCAs. This should allow the UI to remain responsive.
We'll have to see how bad this is when 1000s of HDCAs are being updated (and how that fits into #2126).
Resolves #400