Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI, history: update using xhr date header #2335

Merged
merged 2 commits into from May 10, 2016

Conversation

Projects
None yet
5 participants
@carlfeberhard
Copy link
Contributor

commented May 10, 2016

Makes the 'updated since' contents query based on any previous update's
ajax Date response header instead of the client time. This may offer
more protection against incorrect client time.

This works (and may work better than the previous method) because the
Date header is floored and not rounded and seems to mark a time before
the contents query is made.

Resolves #2242 (hopefully)

UI, history: update using xhr date header
Makes the 'updated since' contents query based on any previous update's
ajax Date response header instead of the client time. This may offer
more protection against incorrect client time.

This works (and may work better than the previous method) because the
Date header is floored and not rounded and seems to mark a time before
the contents query is made.

Resolves #2242 (hopefully)
@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 10, 2016

@carlfeberhard I think this should target release_16.04, if possible.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented May 10, 2016

Definitely fixes #2242 for me, thanks for working this out @carlfeberhard !
And yes, 16.04 would be good.

@dannon

This comment has been minimized.

Copy link
Member

commented May 10, 2016

@carlfeberhard This looks like a good fix to me, I like it. Do you want this applied to 16.04 as well? If so, would you rather retarget this PR or cherrypick the change back?

@carlfeberhard

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2016

@nsoranzo @dannon No, it's meant for 16.07. This isn't a fix for a bug, it's a workaround/enhancement for the corner case where a client is misconfigured. 16.04 is frozen and things that are central like this need more time to shake out before they're in production IMO.

@mvdbeek Glad it's working.

@martenson

This comment has been minimized.

Copy link
Member

commented May 10, 2016

@dannon dannon merged commit 6ca6ba1 into galaxyproject:dev May 10, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented May 10, 2016

Cool, just wanted to check what your intent was.

@carlfeberhard carlfeberhard deleted the carlfeberhard:history.updating-sync branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.