Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tool form to listen to history #2476

Merged
merged 5 commits into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@nturaga
Copy link
Contributor

commented Jun 9, 2016

made changes to tool-form-base.js, this should allow the tool-form to listen to history. Thanks @guerler for walking me through backbone

@martenson martenson added the status/WIP label Jun 9, 2016

@erasche erasche changed the title [WIP] made changes to tool-form-base.js, this should allow the tool-form to… [WIP] allow tool form to listen to history Jul 5, 2016

made changes to tool-form-base.js, this should allow the tool-form to…
… listen to history. Thanks @guerler for walking me through backbone

@nturaga nturaga force-pushed the nturaga:tool_form_listen_history branch from d7a9fa1 to 26b141c Jul 26, 2016

@nturaga nturaga changed the title [WIP] allow tool form to listen to history Allow tool form to listen to history Jul 26, 2016

@nturaga

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2016

@guerler Comments were lost in rebase. Not sure why. I made one of the changes you suggested, but the goal was to get it in before the freeze tomorrow. I figured we can make rest of the changes after, since this works as is.

@galaxybot galaxybot added this to the 16.07 milestone Jul 26, 2016

@guerler guerler self-assigned this Jul 26, 2016

@@ -11,11 +11,26 @@ define(['utils/utils', 'utils/deferred', 'mvc/ui/ui-misc', 'mvc/form/form-view',
this.deferred = new Deferred();
if (options.inputs) {
this._buildForm(options);
this.refresh();

This comment has been minimized.

Copy link
@guerler

guerler Jul 26, 2016

Contributor

This refresh request does not seem to be necessary.

@@ -38,9 +53,7 @@ define(['utils/utils', 'utils/deferred', 'mvc/ui/ui-misc', 'mvc/form/form-view',
operations : !this.options.hide_operations && this._operations(),
onchange : function() {
self.deferred.reset();

This comment has been minimized.

Copy link
@guerler

guerler Jul 26, 2016

Contributor

The reset here should probably be placed into the refresh call. It removes uneccessarily queued requests.

This comment has been minimized.

Copy link
@nturaga

nturaga Jul 26, 2016

Author Contributor

thanks @guerler

@guerler

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2016

+1 waiting for tests to complete.

@guerler guerler merged commit 71151c6 into galaxyproject:dev Jul 26, 2016

1 of 4 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.