Allow tool form to listen to history #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
changed the title
… listen to history. Thanks @guerler for walking me through backbone
nturaga
force-pushed
the
tool_form_listen_history
branch
from
d7a9fa1
to
26b141c
Compare
nturaga
changed the title
|
@guerler Comments were lost in rebase. Not sure why. I made one of the changes you suggested, but the goal was to get it in before the freeze tomorrow. I figured we can make rest of the changes after, since this works as is. |
| @@ -11,11 +11,26 @@ define(['utils/utils', 'utils/deferred', 'mvc/ui/ui-misc', 'mvc/form/form-view', | |||
| this.deferred = new Deferred(); | |||
| if (options.inputs) { | |||
| this._buildForm(options); | |||
| this.refresh(); | |||
There was a problem hiding this comment.
This refresh request does not seem to be necessary.
|
+1 waiting for tests to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made changes to tool-form-base.js, this should allow the tool-form to listen to history. Thanks @guerler for walking me through backbone