Ignore .tox directory. Used to be ignored by default w/ flake8 appar… #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntly, but not anymore.
…s with it still around. (nsoranzo's suggestion)
| @@ -442,7 +442,7 @@ def setup_shed_tools_for_test(app, tmpdir, testing_migrated_tools, testing_insta | |||
| tool_configs.remove(relative_migrated_tool_panel_config) | |||
| for installed_tool_panel_config in INSTALLED_TOOL_PANEL_CONFIGS: | |||
| tool_configs.append(installed_tool_panel_config) | |||
| from galaxy import tools # noqa, delay import because this brings in so many modules for small tests | |||
| from galaxy import tools # delay import because this brings in so many modules for small tests # noqa | |||
There was a problem hiding this comment.
Sure, good to specify. Going to look up the rest of them too.
There was a problem hiding this comment.
Cool, was doing the same! My ack found:
lib/galaxy/model/mapping.py
lib/galaxy/webapps/galaxy/controllers/dataset.py
lib/galaxy/webapps/galaxy/controllers/forms.py
lib/galaxy/webapps/galaxy/controllers/library_common.py
scripts/db_shell.py
… more #noqas to skip the precise relevant exception.
| '_future_expose_api_raw_anonymous', | ||
| '_future_expose_api_anonymous_and_sessionless', | ||
| '_future_expose_api_raw_anonymous_and_sessionless', 'form', | ||
| 'FormBuilder', 'httpexceptions'] |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Aug 10, 2016
Do not pin when forward-merging to dev branch. Also ignore .tox/ and eggs/ as in galaxyproject#2650 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ently, but not anymore.