Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .tox directory. Used to be ignored by default w/ flake8 appar… #2650

Merged
merged 5 commits into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Jul 25, 2016

…ently, but not anymore.

dannon added some commits Jul 25, 2016

Add eggs to blacklist as well, to ignore it in local testing for folk…
…s with it still around. (nsoranzo's suggestion)
@@ -442,7 +442,7 @@ def setup_shed_tools_for_test(app, tmpdir, testing_migrated_tools, testing_insta
tool_configs.remove(relative_migrated_tool_panel_config)
for installed_tool_panel_config in INSTALLED_TOOL_PANEL_CONFIGS:
tool_configs.append(installed_tool_panel_config)
from galaxy import tools # noqa, delay import because this brings in so many modules for small tests
from galaxy import tools # delay import because this brings in so many modules for small tests # noqa

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jul 25, 2016

Member

Add : E402 at the end?

This comment has been minimized.

Copy link
@dannon

dannon Jul 25, 2016

Author Member

Sure, good to specify. Going to look up the rest of them too.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jul 25, 2016

Member

Cool, was doing the same! My ack found:
lib/galaxy/model/mapping.py
lib/galaxy/webapps/galaxy/controllers/dataset.py
lib/galaxy/webapps/galaxy/controllers/forms.py
lib/galaxy/webapps/galaxy/controllers/library_common.py
scripts/db_shell.py

@galaxybot galaxybot added this to the 16.07 milestone Jul 25, 2016

dannon added some commits Jul 25, 2016

Remove two #noqas and specify __all__ for those modules. Specify many…
… more #noqas to skip the precise relevant exception.
'_future_expose_api_raw_anonymous',
'_future_expose_api_anonymous_and_sessionless',
'_future_expose_api_raw_anonymous_and_sessionless', 'form',
'FormBuilder', 'httpexceptions']

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Jul 25, 2016

Member

Awesome, thanks a lot!

@nsoranzo nsoranzo merged commit 134f988 into galaxyproject:dev Jul 25, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Aug 10, 2016

Pin flake8 version
Do not pin when forward-merging to dev branch.
Also ignore .tox/ and eggs/ as in galaxyproject#2650 .

@nsoranzo nsoranzo added the kind/bug label Dec 20, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.