Break tool parameter help words if necessary #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +152,7 @@ | |||
| font-size: 0.8em; | |||
| font-weight: normal; | |||
| top: -1px; | |||
| word-break:break-word; | |||
There was a problem hiding this comment.
I think this had no effect before as break-word seems to not be a valid value (word-break: normal|break-all|keep-all|initial|inherit; http://www.w3schools.com/cssref/css3_pr_word-break.asp)
There was a problem hiding this comment.
It did but not in FF. Its a webkit only feature: http://caniuse.com/#feat=word-break, so should not be used eitherway. Thanks for looking into it.
There was a problem hiding this comment.
I am revisiting this for purposes of #2591
Should we have a break-word on button titles?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids overflow scrolling and forces word breaks for tool parameter help details which were written without spaces between key words. See e.g. GATK tool in workflow editor. Without this fix, the tool form on the right can be scrolled horizontally within in the side panel. This PR also changes remaining word-break settings to word-wrap instead. The latter have wider browser support. Tested with FF, Safari and Chrome (see also: http://www.w3schools.com/cssref/css3_pr_word-wrap.asp).