Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.07] Fix the sanitization of None values in utils. This had previously no… #2693

Merged

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Jul 29, 2016

…t happened because Params had only been sanitizing strings coming in as part of the request, but if you're passing off (potentially manipulated, as in adding None default params) to a secondary request for a response, this can happen.

This resolves an issue @remimarenco found when attempting to download an archive of a composite dataset.

Fix the sanitization of None values in utils. This had previously not…
… happened because Params had only been sanitizing strings coming in as part of the request, but if you're passing off (potentially manipulated, as in adding None default params) to a secondary request for a response, this can happen.

@dannon dannon added this to the 16.07 milestone Jul 29, 2016

@remimarenco

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2016

Thanks for the help! And I guess it will be pushed to 16.04 too as it happens on this release?

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Jul 29, 2016

👍

@jmchilton jmchilton merged commit ed7c357 into galaxyproject:release_16.07 Jul 29, 2016

4 checks passed

api test Build finished. 224 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 111 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.