Functionality to allow admins to switch on/off the line endings conversion on import #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zipho
changed the title
| @@ -12,6 +12,7 @@ | |||
| import sys | |||
| import tempfile | |||
| import zipfile | |||
| import cProfile | |||
There was a problem hiding this comment.
Can you remove these changes?
There was a problem hiding this comment.
These are now removed.
| @@ -12,7 +12,6 @@ | |||
| import sys | |||
| import tempfile | |||
| import zipfile | |||
| import cProfile | |||
There was a problem hiding this comment.
But the other changes to this file seem to remain - the part that used the cProfile import.
There was a problem hiding this comment.
I've removed the changes. The initial commit did'nt carry these.
|
Is there any reasons this has not been merged. I am happy to comply with any suggestions. |
|
LGTM, but ping @martenson (the libraries guru). |
|
works well, thanks @zipho for the contribution and @jmchilton with @nsoranzo for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality to allow admins to switch off the line endings conversion on import.
This is a cleanup to PR #2803